No longer show disabled ports on main ports page #1228

Merged
merged 2 commits into from Jun 11, 2015

Projects

None yet

4 participants

@laf
Member
laf commented Jun 9, 2015

This fixes #1141

In the issue it's shown that ports disabled are showing in eventlog, I can't see that this is possible in the code so that bit hasn't been touched.

However we now no longer show ports marked as disabled in the Webui for all ports or the devices ports. This makes sense as the option is there for the users to control and isn't what we poll / discover.

@laf laf No longer show disabled ports
2a11da5
@laf laf added the WebUI label Jun 9, 2015
@paulgear
Member

I can understand not showing disabled ports on the global ports table, but taking it out of the device table without any way to override it seems a little counter-intuitive to me. If they were hidden by default but there was an AJAX button to show them, that would make a lot more sense to me.

@laf
Member
laf commented Jun 10, 2015

I don't agree personally. But I'll remove that part and update the pr for now.

@SaaldjorMike
Member

👍 for leaving a button that would show the disabled ports on a device.

@laf
Member
laf commented Jun 10, 2015

Pushed a new update that keeps disabled ports back in. Someone can look at extending it further another time. This now just fixes the disabled bit of the main ports list.

@laf laf Added disabled ports back in
c3115eb
@laf laf changed the title from No longer show disabled ports to No longer show disabled ports on main ports page Jun 10, 2015
@f0o f0o merged commit 5677ad7 into librenms:master Jun 11, 2015

1 of 3 checks passed

default Build finished.
Details
Auto-Deploy Build triggered. sha1 is merged.
Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment