Added UPS load support to Synology #1269

Merged
merged 2 commits into from Jun 15, 2015

Projects

None yet

2 participants

@Calvario
Contributor

#1199 Now you can see the UPS load !

Checked and tested.

@Calvario Calvario Added UPS load support to Synology
fbe2f94
@laf
Member
laf commented Jun 13, 2015

Thanks @Calvario

Looks like you're missing 'snmp' from discover_sensor after 'UPSLoad'.

@laf laf added the Discovery label Jun 13, 2015
@laf
Member
laf commented Jun 14, 2015

@Calvario

Checked this further and the order of your parameters to discover_sensor are wrong:

Should be:

discover_sensor($valid['sensor'], 'load', $device, $ups_load_oid, 0, 'snmp', $ups_device_manufacturer.' '.$ups_device_model . 'UPS Load', '1', '1', 0, NULL, NULL, 100, intval($ups_load));

imho.

@Calvario
Contributor

Corrected. Thanks

@laf laf self-assigned this Jun 15, 2015
@laf laf merged commit f192f4b into librenms:master Jun 15, 2015

1 check passed

Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment