Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 Unit Conversion Fix #12857

Merged
merged 2 commits into from May 11, 2021
Merged

PHP 8 Unit Conversion Fix #12857

merged 2 commits into from May 11, 2021

Conversation

wolfraider
Copy link
Contributor

@wolfraider wolfraider commented May 11, 2021

Fix production.ERROR: Unsupported operand types: string / int with older devices and unit conversions.

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/production-error-unsupported-operand-types-string-int/15788/4

@murrant murrant merged commit 60d3729 into librenms:master May 11, 2021
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/21-5-0-changelog/15882/1

@cabello123
Copy link

cabello123 commented Apr 7, 2022

Hello, how are you? I don't know if I have to write here but I still have the error, especially when it comes out when they are UPS equipment, I don't know if it can help

[2022-04-07T09:41:42.832476+02:00] production.ERROR: Error polling core module for 172.30.255.78. Unsupported operand types: st int
#0 /opt/librenms/LibreNMS/Modules/Core.php(92): LibreNMS\Modules\Core->calculateUptime()
#1 /opt/librenms/includes/polling/core.inc.php(14): LibreNMS\Modules\Core->poll()
#2 /opt/librenms/includes/polling/functions.inc.php(329): include('...')
#3 /opt/librenms/poller.php(138): poll_device()
#4 {main}
Someone can help me ?=

@cabello123
Copy link

someone can help me ?

@murrant
Copy link
Member

murrant commented Apr 18, 2022

@cabello123 this is absolutely the wrong place to ask. You are lucky I even saw it to respond. Please ask for help at https://community.librenms.org or Discord. Also, your message is incomplete. please try to capture fresh.

@librenms librenms locked as off-topic and limited conversation to collaborators Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants