Add timeout on unix agent execution after connect. #1319

Merged
merged 2 commits into from Jun 21, 2015

Projects

None yet

3 participants

@spinza
Contributor
spinza commented Jun 21, 2015

I was seeing agent execution getting stuck but without time-out occurring. I.e. the poller was connecting to the port but not streaming data which should result in timeout.

This adds a stream time-out to fix that.

@spinza
Contributor
spinza commented Jun 21, 2015

One question that's whether to continue processing the data if the agent had timed out during fetch. Means we have partial data. At the moment it is processing whatever data has been fetched. So if it's usable it will be used.

@laf
Member
laf commented Jun 21, 2015

I'd say grab what data we can.

Prob worth setting this to be a user controlled variable so people can increase / decrease the timeout.

@spinza
Contributor
spinza commented Jun 21, 2015

The existing connection time-out is 10s hard coded. Just stuck with that, but can change if you want.

@spinza spinza Add config settings for unix-agent time-outs.
7cda1da
@spinza
Contributor
spinza commented Jun 21, 2015

OK, I've added config settings for both time-outs.

@laf laf merged commit 35f784c into librenms:master Jun 21, 2015

2 checks passed

Auto-Deploy Build finished.
Details
Scrutinizer No new issues
Details
@spinza spinza deleted the unknown repository branch Jun 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment