API Call to set instant Maintenance mode #13237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: https://community.librenms.org/t/scheduling-maintenance-via-api/9517/10 |
SourceDoctor
changed the title
murrant
reviewed
Sep 21, 2021
murrant
reviewed
Sep 21, 2021
|
@SourceDoctor test that. I removed several unnecessary queries. |
|
@murrant ? |
|
@SourceDoctor your code merge broke things :) I think I fixed it. |
murrant
approved these changes
Sep 28, 2021
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
eskyuu
pushed a commit
to eskyuu/librenms
that referenced
this pull request
Oct 21, 2021
* API Call to set instance Maintenance mode * . * remove unused code * update query * Use recent code * remove accidental line return * fix duration in success string * style fix * Try to fix bad code merge Co-authored-by: Tony Murray <murraytony@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a device instant into Maintenance Mode via API Call
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.