Currently users cannot use the check_mk apache plugin to monitor the apache instance that is running librenms. Excluding server-status from the rewrite rules allows users to use mod_status.
Do not rewrite server-status
Auto-Deploy finished, Test PR at http://1339.ci.librenms.org or https://1339.ci.librenms.org
I'd prefer the user to configure Name Based VirtualHosts in apache2 (same applies for nginx's equivalent).
/server-status & co shouldnt be listening on anything other than 127.0.0.1 anyhow if you ask me..
Restricting server-status to localhost can be done by setting the Allow directives in the Location section of the virtualhost.
The check_mk script polls by default on port 80, so if I want it to coexist with librenms, I either have to set librenms to listen on a specific address, rather than * or edit the check_mk script.
In the end the admin can choose either way they want to use server-status, keeping librenms from stomping on it just makes one of the easier methods work out of the box.
Unassigning myself, I dont think it's a good idea - apache2 supports virtualhosts for a reason and from my pov the described situation is a perfect usecase for it.
However, I'm not going on a riot if somebody else from the team agrees with you and merges it ;)
I think the fact we ship a httpd config file to bind librenms to all interfaces says we should allow this so merged in.