Adding --daemon twice breaks collectd graphs #1342

Merged
merged 1 commit into from Jun 25, 2015

Projects

None yet

3 participants

@clinta
Contributor
clinta commented Jun 25, 2015

When using rrdcached rrdtool.inc.php already adds the necessary options. Collectd.inc.php adds them again which breaks drawing the graphs.

@clinta clinta Adding --daemon twice breaks collectd graphs
When using rrdcached [rrdtool.inc.php](includes/rrdtool.inc.php#L163) already adds the necessary options. Collectd.inc.php adds them again which breaks drawing the graphs.
dd5d1c5
@laf
Member
laf commented Jun 25, 2015

Thanks for the PR @clinta. As an FYI for further PRs - especially bigger ones can you sign the contributors agreement (example: #1237).

For now this is such a simple bug fix that we'll merge it in :)

@laf laf merged commit 9dedd75 into librenms:master Jun 25, 2015

2 checks passed

Auto-Deploy Build finished.
Details
Scrutinizer No new issues
Details
@laf laf added the Bug label Jun 25, 2015
@clinta clinta deleted the unknown repository branch Jun 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment