entropy DS name is value. #1349

Merged
merged 1 commit into from Jun 26, 2015

Projects

None yet

3 participants

@clinta
Contributor
clinta commented Jun 26, 2015

Another bug in collectd graphs. The DS name for the entropy graph has been changed in collectd from 'entropy' to 'value'.

@clinta clinta entropy DS name is value.
02780b8
@laf
Member
laf commented Jun 26, 2015

Do we need to do a check for collectd version first to see which names to use?

I can see they changed it in 2010 but don't want to break existing installations for those it may be working for. If it's very unlikely that people will be running such an old version then I guess we could switch.

@clinta
Contributor
clinta commented Jun 26, 2015

It looks like the first release with this change was in collectd 5.0 released 2011-03-28. If you think it'd be appropriate to add a note to the configuration document that collectd 5.0 or greater is required I'd be happy to do that.

Otherwise I suppose it would need to call rrdtool info to check wether it has the DS 'entropy' or 'value'.

@laf
Member
laf commented Jun 26, 2015

I can see f0o merged a similar change and 2011 is old enough I'd say.

@laf laf merged commit aed0fed into librenms:master Jun 26, 2015

2 checks passed

Auto-Deploy Build finished.
Details
Scrutinizer No new issues
Details
@laf laf removed the Needs-Info label Jun 26, 2015
@clinta clinta deleted the unknown repository branch Jun 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment