Fix datepicker timezone issue(s) #1374, #1239, #1241 #1376

Merged
merged 21 commits into from Jul 5, 2015

Projects

None yet

4 participants

@travishegner
Contributor

Basically, passing the unix timestamp straight from PHP without a format, and then using javascript to format the date on page load. With this, javascript automatically converts the format to browser time.

On form submission, changed the parsing to be done by moment.js since we already have it loaded and it seems to do better with cross browser compatibility, and again auto handles the browser's time conversion.

Also fixed a missing semicolon in the same code block.

Fixes: #1374, #1239, #1241

@travishegner travishegner Merge remote-tracking branch 'upstream/master' into datepicker
67257f8
@clinta
Contributor
clinta commented Jul 2, 2015

Curious, what's the login info for the CI builds? admin/admin doesn't seem to work.

@laf
Member
laf commented Jul 2, 2015

root
toor

Super secret :)

@travishegner
Contributor

It looks like the only issue left is that the RRD graph's timeline is that of the server's timezone (or perhaps UTC, I'm not sure). If the browser is in the same timezone as the server, then you won't notice obviously, but in any case I think this is still an improvement over how it works currently.

@laf
Member
laf commented Jul 5, 2015

Awesome work @travishegner :)

@laf laf merged commit 1380230 into librenms:master Jul 5, 2015

2 checks passed

Auto-Deploy Build finished.
Details
Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment