Do not allow the master to join twice #1377

Merged
merged 1 commit into from Jul 5, 2015

Projects

None yet

4 participants

@clinta
Contributor
clinta commented Jul 2, 2015

If the poller master doesn't complete in time and ends up with overlapping jobs, neither job will ever complete because both running jobs will think they are the master and wait for the remaining node to exit.

@clinta clinta Do not allow the master to join twice
If the poller master doesn't complete in time and ends up with overlapping jobs, neither job will ever complete because both running jobs will think they are the master and wait for the remaining node to exit.
fd0617a
@f0o
Member
f0o commented Jul 2, 2015

👍

@f0o f0o added the Polling label Jul 2, 2015
@laf
Member
laf commented Jul 3, 2015

deployed to a two poller node setup with 2600+ devices. Will feedback in a day or two.

@laf
Member
laf commented Jul 5, 2015

Ok, all running ok and I don't see any issues with the code.

@laf laf merged commit 50338c2 into librenms:master Jul 5, 2015

2 checks passed

Auto-Deploy Build finished.
Details
Scrutinizer No new issues
Details
@clinta clinta deleted the unknown repository branch Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment