Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DefaultWidgetSeeder #14006

Merged
merged 2 commits into from Jun 4, 2022
Merged

Conversation

murrant
Copy link
Member

@murrant murrant commented Jun 1, 2022

Remove the direct reference to DefaultWidgetSeeder in includes/sql-schema/update.php, it is no longer valid.

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added the Cleanup label Jun 1, 2022
@murrant murrant merged commit 2f4c7ce into librenms:master Jun 4, 2022
@murrant murrant deleted the fix-widgets-seeder branch June 4, 2022 18:11
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/22-6-0-changelog/18968/1

Npeca75 pushed a commit to Npeca75/librenms that referenced this pull request Jun 22, 2022
* Remove DefaultWidgetSeeder

* Fix style
Npeca75 pushed a commit to Npeca75/librenms that referenced this pull request Jul 25, 2022
* Remove DefaultWidgetSeeder

* Fix style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants