Fix coding style old files (part 2) #1444

Merged
merged 1 commit into from Jul 15, 2015

Projects

None yet

4 participants

@job
Contributor
job commented Jul 13, 2015

Ran phpcbf over all PHP files that were not touched in the last code style fixing round. I did a manual clean up on every file after phpcbf. Excluded third party libraries. This is my last code style PR.

@job
Contributor
job commented Jul 13, 2015

I will squash this when you are ready to merge.

@job
Contributor
job commented Jul 14, 2015

trigger ci

@laf
Member
laf commented Jul 14, 2015

@job

adduser.php - The copyright has changed in this to 2013, we forked the code from 2012 so copyright needs to stay the same. - That's happened a number of files actually.

Some of the functions have been changed from:

functionname() {

to

functionname()
{

Is it because it then adds // end functionname() or can that behaviour be changed?

Aside from that those, I can't see any issues.

@laf
Member
laf commented Jul 14, 2015

p.s also needs a rebase.

@job job Fix coding style part 2
361653a
@f0o f0o merged commit 4ebabc6 into librenms:master Jul 15, 2015

2 checks passed

Auto-Deploy Build finished.
Details
Scrutinizer 1441 Issues, 19 Patches
Details
@job
Contributor
job commented Jul 15, 2015

trigger ci

@job
Contributor
job commented Jul 15, 2015

This can be closed, continuing in #1449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment