Added PowerConnect 3548 support #1452

Merged
merged 5 commits into from Jul 16, 2015

Projects

None yet

3 participants

@alangregory
Contributor

No description provided.

@alangregory alangregory Added PowerConnect 3548 support
b931e5d
@laf
Member
laf commented Jul 15, 2015

Hi @alangregory

We've just gone through a big update to fix code formatting so we will be a little stricter now on how files are formatted. Please take a look at: http://docs.librenms.org/Developing/Code-Guidelines/ to help fix some of the issues in this file and if you can update the PR that would be great.

Thanks.

@laf laf added the Discovery label Jul 15, 2015
@alangregory alangregory Fixed some code standards
be67013
@alangregory
Contributor

@laf Some code was old, check is it's ok now

@laf
Member
laf commented Jul 15, 2015

Thanks @alangregory.

Still some not quite right, check the Files changed tab at the top of here but things like:

if ($device['os'] == "powerconnect")
{

foreach (explode("\n",$temps) as $oids)
{

Also you don't need to use " when echoing and not using variables so:

$descr = "Internal Temperature";

Should be:

$descr = 'Internal Temperature';

Thanks.

@alangregory
Contributor

Ok, i'll fix it, thats the old code part.

@alangregory alangregory Updated old code and fixed some code standards
d1c7886
@laf
Member
laf commented Jul 16, 2015

Thanks. It looks like lines (in the old file) 3,4, 13, 41 and 42 are still being updated when they shouldn't be, you don't need a space after snmp_get or before the , in each of the items in the function + if () { needs to be on one line still.

alangregory added some commits Jul 16, 2015
@alangregory alangregory Updated standards
c3db4f4
@alangregory alangregory REmoved aditional space
54cc274
@laf laf merged commit 3de258a into librenms:master Jul 16, 2015

2 checks passed

Auto-Deploy Build finished.
Details
Scrutinizer 3 new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment