changes needed to run under a web server subdirectory #1667

Merged
merged 5 commits into from Aug 14, 2015

Projects

None yet

3 participants

@miken32
Contributor
miken32 commented Aug 11, 2015

Trying again. Code in vars.php shouldn't mess with sites without a subdirectory!

@miken32 miken32 update AUTHORS
0dfbf71
@laf
Member
laf commented Aug 13, 2015

👍 from me, works as standard on apache without using sub dir.

Also works on CI.

Proposing we merge and if we find any specific issues with sub dir support we fix along the way.

@laf
Member
laf commented Aug 13, 2015

@miken32

Thanks for this updated PR, we are hoping to merge tomorrow morning but can you push a commit with contributors agreement, I know you've signed the page but we need the commit message to be the specific one - you did it on the last pr but we had to roll that back. If you can do that asap then we will be able to merge :)

@miken32 miken32 I agree to the conditions of the Contributor Agreement contained in d…
…oc/General/Contributing.md.
cde6da7
@miken32
Contributor
miken32 commented Aug 13, 2015

Done, sorry I forgot about that!

@laf laf merged commit 0737722 into librenms:master Aug 14, 2015

2 checks passed

Auto-Deploy Build finished.
Details
Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment