New and Awesome IRC-Bot! #171

Merged
merged 2 commits into from Mar 13, 2014

Projects

None yet

3 participants

@f0o
Member
f0o commented Mar 7, 2014

No description provided.

@f0o f0o referenced this pull request Mar 7, 2014
Closed

New and Improved IRC-Bot #166

@laf
Member
laf commented Mar 8, 2014

Works for me, can't see any issue in the code. My only comment would be around why declare a connection to mysql when this is done in includes/definitions.inc.php?

@f0o
Member
f0o commented Mar 8, 2014

Oh I see that the link gets saved in $observium_link, I can use this instead.
However it wont replace the chkdb() function because I need to track the availability of the MySQL-Resource and be able to re-connect to the SQL if it got closed in the meantime.

@paulgear paulgear merged commit e6cb797 into librenms:master Mar 13, 2014

1 check passed

default Scrutinizer: 66 new/changed issues, 34 added/modified code elements
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment