Eliminate if debug then echo #1725

Merged
merged 7 commits into from Aug 21, 2015

Projects

None yet

2 participants

@tuxis-ie
Contributor

This should remove all the useless-uses-of if-then-else to do debug output...

@laf
Member
laf commented Aug 21, 2015

Hi @tuxis-ie, you will need to rebase this commit before we can merge.

@laf
Member
laf commented Aug 21, 2015

Also, you need to sign the contributors agreement, see paulgear@63f3676 as an example.

@tuxis-ie
Contributor

Done, both...

@laf
Member
laf commented Aug 21, 2015

@tuxis-ie checking through the code now, scrutinizer has found two syntax issues which need to be resolved:

https://scrutinizer-ci.com/g/librenms/librenms/inspections/266f4e53-2165-425f-b339-126a1fb42a6a/issues/

@laf
Member
laf commented Aug 21, 2015

Once the two scrut issues are fixed then I think this is fine for a merge, just checked through all the files and all looks good. No graphing issues on my install for 30+ mins.

@laf laf merged commit f2045b3 into librenms:master Aug 21, 2015

1 check passed

Scrutinizer No new issues
Details
@tuxis-ie tuxis-ie deleted the tuxis-ie:eliminate-if-debug branch Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment