Highlight table on hover, added column names for status and brand #1738

Merged
merged 3 commits into from Aug 23, 2015

Projects

None yet

3 participants

@arjitc
Contributor
arjitc commented Aug 22, 2015
@f0o
Member
f0o commented Aug 23, 2015

table-condensed can be used together with table-hover afaik - or is there any reason why you removed it?

@f0o f0o self-assigned this Aug 23, 2015
@f0o f0o added the WebUI label Aug 23, 2015
@laf
Member
laf commented Aug 23, 2015

I think brand should be vendor as well.

@arjitc
Contributor
arjitc commented Aug 23, 2015

Changed brand to vendor and added back table-condensed :)

@laf
Member
laf commented Aug 23, 2015

Thanks, merging this in now.

We do have a new contributors agreement which we could do with you signing. It's ok for this pr as its specific to us but if you could submit an updated agreement that would be ace.

@laf laf merged commit 068c973 into librenms:master Aug 23, 2015

1 check passed

Scrutinizer No new issues
Details
@arjitc
Contributor
arjitc commented Aug 23, 2015

We do have a new contributors agreement which we could do with you signing. It's ok for this pr as its specific to us but if you could submit an updated agreement that would be ace.

I had signed one a few months ago when I did my initial UI related commits, I then had to leave to go to another city for a while, back home now so not sure if it has changed, let me know if it has changed and I'll re-sign it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment