Ability to override the ports ifAlias #1811

Merged
merged 7 commits into from Sep 1, 2015

Projects

None yet

3 participants

@laf
Member
laf commented Aug 30, 2015

Fix #1689

WebUI has been updated in Device -> Edit -> Port Settings. You can now edit the Description which is updated on change. A devices_attrib entry is then stored to indicate that the port description has been manually set.

If the user removes the description it will then be re-polled.

Honours the port parser code so you can manually set say Cust: Customer A and have it pick the port up as a customer port and do everything else you would expect.

Updated get_dev_attrib() to accept the value to be looked up as well to save checking the output of get_dev_attrib to see if the ifName is the one we are currently checking against. values are stored against ifName so this shouldn't break if a port is deleted and re-added say for a ppoe port.

@laf laf added Polling WebUI labels Aug 30, 2015
@laf laf Scrut fix
0f9ac4a
@f0o f0o commented on the diff Aug 31, 2015
html/pages/device/edit/ports.inc.php
@@ -1,10 +1,12 @@
+</form>
<span id="message"><small><div class="alert alert-danger">n.b For the first time, please click any button twice.</div></small></span>
@f0o
f0o Aug 31, 2015 Member

n.b For the first time, please click any button twice. ?

@laf
laf Aug 31, 2015 Member

That's from another PR not this one - I can't get the Javascript to fire the first time for clicking the all buttons so had to put that in so people were aware.

Unrelated to this PR though :)

@f0o f0o merged commit 8ade12d into librenms:master Sep 1, 2015

2 checks passed

Auto-Deploy Build finished.
Details
Scrutinizer No new issues
Details
@laf laf deleted the laf:issue-1689 branch Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment