Add support for SonicWALL CPU and memory graphs #1957

Merged
merged 11 commits into from Sep 22, 2015

Projects

None yet

3 participants

@ciscoqid
Contributor

Please note - this depends on a pending pull request in librenms-mibs for the SonicWALL MIBs used in these changes. Memory is only reported in percent, so incorrectly reports as bytes. It would be nice to adjust presentation to include units optionally for this sort of situation.

ciscoqid added some commits Sep 21, 2015
@ciscoqid ciscoqid Create sonicwall.inc.php
Discovery module for SonicWALL memory utilization.
8c20f54
@ciscoqid ciscoqid Create sonicwall-mem.inc.php
Memory utilization module for SonicWALL firewalls.
2a807c0
@ciscoqid ciscoqid Merge pull request #1 from ciscoqid/patch-1
Create sonicwall.inc.php
67e8dcd
@ciscoqid ciscoqid Update definitions.inc.php a05575d
@ciscoqid ciscoqid Create sonicwall.inc.php 4df8148
@ciscoqid ciscoqid Update definitions.inc.php
Extended new SonicWALL monitoring to include both CPU and memory graphs.
871258d
@laf
Member
laf commented Sep 22, 2015

Thanks @ciscoqid.

So a couple of things for us to be able to merge in:

  1. Can you add the MIB as another commit to this PR please, we aren't currently using librenms-mibs so it will need to be added here instead. Please include the URL to where you got the mib in the commit message.
  2. Most of your formatting looks good, however you have some indentation issues in includes/polling/mempools/sonicwall-mem.inc.php. We use 4 spaces for an indent and each block needs to be indented. An example:

if something() {
    echo "Yes";
        if newthing() {
            echo "No";
        }
}
@ciscoqid ciscoqid Update sonicwall-mem.inc.php
Updated to conform to coding standard, added copyleft header.
82af247
@ciscoqid
Contributor

I have updated the files as requested, added the MIB files to the pull request.

@laf
Member
laf commented Sep 22, 2015

Close, you've now updated includes/discovery/mempools/sonicwall.inc.php and the indentations are now wrong. If you can fix that then we're good for a merge.

@ciscoqid
Contributor

Hmm, not sure what lead to that, dang it! I will fix...

Thanks,
Mark

Sent from my iPhone

On Sep 22, 2015, at 1:43 PM, Neil Lathwood notifications@github.com wrote:

Close, you've now updated includes/discovery/mempools/sonicwall.inc.php and the indentations are now wrong. If you can fix that then we're good for a merge.


Reply to this email directly or view it on GitHub.

This message has been scanned by CanIt-PRO.

BEGIN-ANTISPAM-VOTING-LINKS

Teach CanIt if this mail (ID 03PkkHNcM) is spam:
Spam: https://canit.willingminds.com/canit/b.php?i=03PkkHNcM&m=4cc1af57bb42&t=20150922&c=s
Not spam: https://canit.willingminds.com/canit/b.php?i=03PkkHNcM&m=4cc1af57bb42&t=20150922&c=n

Forget vote: https://canit.willingminds.com/canit/b.php?i=03PkkHNcM&m=4cc1af57bb42&t=20150922&c=f

END-ANTISPAM-VOTING-LINKS

@ciscoqid ciscoqid Update sonicwall.inc.php
Fixed indentation again!
46bb776
@ciscoqid
Contributor

Yeah, weird -- not sure how those extra 2 spaces crept in there. Need to stop using the editor in the web UI I guess -- will switch as soon as I my environment setup properly. Try again!

Thanks,
Mark

@laf
Member
laf commented Sep 22, 2015

Boom :)

@laf laf merged commit cea7aca into librenms:master Sep 22, 2015

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer 11 new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment