Improvements to distro script: Arch Linux support, only use lsb-release as a fallback #1978

Merged
merged 4 commits into from Sep 23, 2015

Projects

None yet

5 participants

@n-st
Contributor
n-st commented Sep 22, 2015

No description provided.

@laf
Member
laf commented Sep 22, 2015

@f0o you may be better at checking this as I don't really poll servers. Looks ok from my perspective.

@f0o f0o was assigned by laf Sep 22, 2015
@paulgear
Member

Not sure why we would want to remove the LSB stuff...

@n-st
Contributor
n-st commented Sep 23, 2015

@paulgear We're not removing anything, just preferring the distribution-specific version detection code over the generic one.
Right now, the script detects and parses files like /etc/debian_version, but discards those results if /etc/lsb_release exists.
I really can't think of a reason why we would want to do that. In fact, this looks suspiciously like an oversight (accidental if instead of elif) to me...

@paulgear
Member

@n-st OK - I'll look more closely at the full script when I get a sec. From the diff it looked like it was discarding the LSB stuff needlessly.

@f0o
Member
f0o commented Sep 23, 2015

👍

@f0o f0o merged commit 20adc26 into librenms:master Sep 23, 2015

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment