Added working memcached support #2007

Merged
merged 5 commits into from Oct 1, 2015

Projects

None yet

3 participants

@f0o
Member
f0o commented Sep 27, 2015

Added generic memcached support to dbFacile.*

Remove now obsolete memcached code in:

  html/ajax_rulesuggest.php

Remove all the broken memcached code in:

  html/pages/device/health/mempool.inc.php
  html/pages/device/overview/generic/sensor.inc.php
  html/pages/device/overview/mempools.inc.php
  html/pages/device/port.inc.php
  html/pages/device/ports.inc.php
  html/pages/health/sensors.inc.php
  includes/polling/functions.inc.php
  includes/polling/mempools.inc.php
  includes/polling/ports.inc.php
  includes/polling/storage.inc.php
@f0o f0o Added generic memcached support to dbFacile.*
Remove now obsolete memcached code in:
  html/ajax_rulesuggest.php

Remove all the broken memcached code in:
  html/pages/device/health/mempool.inc.php
  html/pages/device/overview/generic/sensor.inc.php
  html/pages/device/overview/mempools.inc.php
  html/pages/device/port.inc.php
  html/pages/device/ports.inc.php
  html/pages/health/sensors.inc.php
  includes/polling/functions.inc.php
  includes/polling/mempools.inc.php
  includes/polling/ports.inc.php
  includes/polling/storage.inc.php
7832868
@f0o f0o added Bug Core labels Sep 27, 2015
f0o added some commits Sep 27, 2015
@f0o f0o scrut fixes
41d996e
@f0o f0o Added docs
a321ba1
@f0o f0o referenced this pull request in QuxLabs/LibreNMS Sep 28, 2015
Closed

Rewrite Memcached integration #8

@laf
Member
laf commented Sep 28, 2015

Anyway to exclude certain lookups from being cached?

The output from /pollers/tab=pollers/ shouldn't be cached really as it stops being able to work out when a poller has completed. I expect we might have a few more pages like that as well.

@laf laf and 1 other commented on an outdated diff Sep 28, 2015
includes/definitions.inc.php
@@ -30,6 +30,22 @@
$database_db = mysql_select_db($config['db_name'], $database_link);
}
+$config['time']['now'] = time();
+$config['time']['now'] -= ($config['time']['now'] % 300);
@laf
laf Sep 28, 2015 Member

I realise this code existed before but any reason you can see not to put this into one line?

@f0o
f0o Sep 30, 2015 Member

It spares 1 time() call :)

@f0o f0o Added `$nocache` parameter
Fixed typo in caching
Excluded caching for MySQL-Authentication & /poll-log/
afdbb24
@f0o f0o Excluded more pages from caching
511f4e9
@laf laf merged commit e2dfab4 into librenms:master Oct 1, 2015

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer 14 new issues
Details
@f0o f0o added a commit that referenced this pull request Oct 2, 2015
@f0o f0o Update index.php
Hotfix for #2007
335a68b
@f0o f0o referenced this pull request Oct 2, 2015
Merged

Update index.php #2038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment