Fix rrd creation parameters #2010

Merged
merged 2 commits into from Sep 28, 2015

Projects

None yet

3 participants

@f0o
Member
f0o commented Sep 28, 2015

Since #1748 we use proc_open instead of shell_exec, so all rrds that have \ in their parameters break.

This PR attempts to fix it by removing all the backslashes.

This PR also fixes a small logic flaw in rrdcached selection :)

@f0o f0o Fix rrd creation parameters
7d95e94
@f0o f0o added the Bug label Sep 28, 2015
@f0o f0o Strip newlines from arguments on creation
afd83f6
@Rosiak
Contributor
Rosiak commented Sep 28, 2015

👍

@Rosiak Rosiak merged commit d8e71a3 into librenms:master Sep 28, 2015

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment