Thanks to f0o for this fix. Bye bye issue #202 #203

Merged
merged 1 commit into from Mar 28, 2014

Projects

None yet

4 participants

@toyowheelin
Contributor

This addresses issue #202

@f0o
Member
f0o commented Mar 17, 2014

👍 looks good here

@laf
Member
laf commented Mar 17, 2014

Worked for me as well on all my different interfaces.

@paulgear
Member

Does this do what I think it does (i.e. sets $ifname with a function, then ignores the result and sets it to something different)?

@laf
Member
laf commented Mar 25, 2014

To me it uses the results of $ifname from the function to grab one value from the array returned. $ifname is then used elsehwhere to set the interface name on the realtime graph.

@paulgear
Member

Right - I missed the right hand side of the dual assignment. I personally think assigning the variable to an array and then reassigning it to a member of that same array is not a clear coding style.

@paulgear paulgear merged commit 5e4ca7e into librenms:master Mar 28, 2014

1 check failed

default Scrutinizer: Errored
Details
@toyowheelin toyowheelin deleted the toyowheelin:issue-202 branch Mar 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment