Moved Device Groups menu #2049

Merged
merged 4 commits into from Oct 6, 2015

Projects

None yet

4 participants

@alangregory
Contributor

Better Visualization

Before:
rsz_old

After:
rsz_after

alangregory added some commits Oct 2, 2015
@alangregory alangregory Moved Device Groups SubMenu
Space fix
4ee9200
@alangregory alangregory Fix double query
4f6fa8a
@alangregory alangregory changed the title from Groups to Moved Device Groups menu Oct 2, 2015
@laf
Member
laf commented Oct 3, 2015

What are your thoughts on putting it in both places? Good to have it in the new position but if you're looking for a device and you're already in the devices menu then it just means having to go to another sub-menu.

Probably also worth calling it Device Groups?

@alangregory
Contributor

It'll only apear on main menu, not inside "All Devices". I'll change name.

@alangregory alangregory Renamed menu name.
20db0e2
@f0o
Member
f0o commented Oct 6, 2015

Can you make the hover-effect of the Groups entry to be a pointer and not a marker cursor?
I think there is just a class missing in your <a>-tag

@f0o f0o added the WebUI label Oct 6, 2015
@f0o f0o self-assigned this Oct 6, 2015
@alangregory alangregory Fixed missing href
7b15f2d
@alangregory
Contributor

Missing href kkk

@f0o
Member
f0o commented Oct 6, 2015

👍

On October 6, 2015 1:37:36 PM GMT+02:00, Alan Gregory notifications@github.com wrote:

Missing href kkk


Reply to this email directly or view it on GitHub:
#2049 (comment)

@f0o f0o merged commit 608aaf9 into librenms:master Oct 6, 2015

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment