Removed what appears to be unecessary STACK text #2097

Merged
merged 2 commits into from Oct 10, 2015

Projects

None yet

4 participants

@laf
Member
laf commented Oct 10, 2015

Fix #2092

Seems ok for me on both 1.4.x and 1.5.x rrdtool but please give it a test.

@laf laf Removed what appears to be unecessary STACK text
0172190
@laf laf added the Graphs label Oct 10, 2015
@f0o f0o and 1 other commented on an outdated diff Oct 10, 2015
html/includes/graphs/generic_multi_seperated.inc.php
@@ -70,10 +70,6 @@
$rrd_options .= ' VDEF:tot'.$i.'=octets'.$i.',TOTAL';
}
- if ($i) {
- $stack = 'STACK';
- }
-
$rrd_options .= ' AREA:inbits'.$i.'#'.$colour_in.":'".rrdtool_escape($rrd['descr'], 9)."In '$stack";
@f0o
f0o Oct 10, 2015 Member

what about that loose $stack here?

@SaaldjorMike
SaaldjorMike Oct 10, 2015 Member

There is also another loose $stack at line 83.

@laf laf Removed unused variables
801e4e1
@laf
Member
laf commented Oct 10, 2015

Removed variables.

@f0o f0o merged commit 93ebc48 into librenms:master Oct 10, 2015

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
@laf laf deleted the laf:issue-2092 branch Oct 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment