Added ability to turn off icmp checks globally or per device #2131

Merged
merged 7 commits into from Oct 17, 2015

Projects

None yet

4 participants

@laf
Member
laf commented Oct 13, 2015

Fix #1936

Includes docs to explain the config option and a warning.

This is still on by default so doesn't affect installs until changed.

laf added some commits Oct 13, 2015
@laf laf Should have been an && :(
2f30848
@laf laf Scrut fix
658f6fa
@Rosiak
Contributor
Rosiak commented Oct 16, 2015

👍
Tested on dev machine.

@SaaldjorMike SaaldjorMike commented on an outdated diff Oct 17, 2015
html/pages/device/edit/misc.inc.php
@@ -3,6 +3,12 @@
echo '
<form class="form-horizontal">
<div class="form-group">
+ <label for="oxidized" class="col-sm-2 control-label">Disable ICMP Test?</label>
@SaaldjorMike
SaaldjorMike Oct 17, 2015 Member

This should not say for="oxidized"

@laf laf Updated for field
0af676e
@SaaldjorMike SaaldjorMike merged commit c653e3c into librenms:master Oct 17, 2015

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer 1449 Issues, 18 Patches
Details
@laf laf deleted the laf:issue-1936 branch Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment