Removed ignored,deleted and disabled ports from query #2213

Merged
merged 1 commit into from Oct 29, 2015

Projects

None yet

4 participants

@laf
Member
laf commented Oct 26, 2015

Fix #2201

I'm not 100% sure on this one, I've fixed the issue anyway but I believe the reason it was like that is so you only see up ports which aren't disabled, ignored or deleted which kind of makes more sense.

Feel free to merge or not :)

@laf laf Removed ignored,deleted and disabled ports from query
fe7b88d
@laf
Member
laf commented Oct 28, 2015

@librenms/reviewers thoughts on this one?

@paulgear
Member

👍 Given that searching for ports that are both up and ignored is a useful function, and also there are tickboxes for disabled, ignored, and deleted on that same page, I think this is a good move. It follows the principle of least astonishment that the tickboxes should be the only things which filter the disabled/ignored/deleted state.

@f0o f0o merged commit 97e36f0 into librenms:master Oct 29, 2015

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
@laf laf deleted the laf:issue-2201 branch Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment