Updated all device edit pages #239

Merged
merged 4 commits into from Jun 25, 2014

Projects

None yet

2 participants

@laf
Member
laf commented Jun 20, 2014

No description provided.

@laf
Member
laf commented Jun 20, 2014

Scrutinizer issues are code duplicated across project and also issues nothing to do with this PR!

@paulgear
Member

One thing that the Scrutinizer report indicates is that we need to make better use of internal library functions, e.g. https://scrutinizer-ci.com/g/librenms/librenms/inspections/c2cf9f29-66b5-4fcd-b131-57b6ae74a6b1/issues/files/html/forms/discovery-module-update.inc.php?status=new&orderField=path&order=asc

As these come up I'm going to create issues for them.

I'd like to test this code a little more before merging.

@laf
Member
laf commented Jun 23, 2014

No probs. I have tested each page to make sure the db is updated correctly as things are ticked/unticked and changed. Not come across any issues with it.

@laf
Member
laf commented Jun 25, 2014

Reminder to update poller module files to use a function

@paulgear paulgear merged commit 7775cf9 into librenms:master Jun 25, 2014

1 check passed

default Scrutinizer: 10 new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment