The dashboard functionality relies on the fact that the user exists in the database. Currently the AD-authentication functionality doesn't implement this feature which breaks the usage of dashboards for anyone except the local admin account.
I've chosen to not implement the insertion of AD-users passwords into the database to keep things safer.
A thing to be considered here would be the "caching" (i.e insert password into the database) of AD-users in case of connection loss towards the AD, however I felt it was out of scope for this fix.
Merge branch 'active_directory_auth' of https://github.com/fstern/lib…
Merge branch 'master' of https://github.com/librenms/librenms
Signed-off-by: Peter Lamperud <email@example.com>
Functionality added: adduser(), user_exists_in_db()
Auto-Deploy finished, Test PR at http://2434.ci.librenms.org or https://2434.ci.librenms.org
Any reason why you're suppressing the dbFetchCell call with @? Just return the count and and check if it's > 0 maybe?
Pure brainfart leaving it there, leftover from testing stuff so it can be removed.
Well spotted :)
@vizay if you can update this PR that would be great.
We also need you to sign the contributors agreement, as an example: Lupul@0557f34
You can do this by submitting an additional commit to this PR.
I agree to the conditions of the Contributor Agreement contained in d…