Modify Menubar #2450

Merged
merged 3 commits into from Nov 20, 2015

Projects

None yet

4 participants

@adaniels21487
Contributor
  • Small Screens - Icon only - Wrap the label in a span with hidden-sm
  • Medium Screen - Text only - add hidden-md to the icon
  • Large Devices - shrink the left/right padding on .nav>li>a to 10px.

Resolves #2168.

@adaniels21487 adaniels21487 Modify Menubar
- Small Screens - Icon only - Wrap the label in a span with hidden-sm
- Medium Screen - Text only - add hidden-md to the icon
- Large Devices - shrink the left/right padding on .nav>li>a to 10px.
2a52b93
@Rosiak
Contributor
Rosiak commented Nov 18, 2015

For some reason the text from the "plugins" icon is removed, so only the icon is displayed(No matter the screen size).
screen shot 2015-11-18 at 09 56 52

Other than that, I think we should keep the LibreNMS icon, when resizing the screen.
screen shot 2015-11-18 at 09 56 09

But I like the work that has been done!

@adaniels21487
Contributor

Hi @Rosiak,
Are you suggesting to break the current image into 2 (Icon and Text) and always keep the icon and display the text only if the user is on a large screen?
Currently, this image is user configurable via $config['title_image']. Is the intention to have our icon fixed and our text or the users image configurable?

Also, the menubar has the following test: if ($config['title_image']), but definitions.inc.php has the following:

if (!isset($config['title_image'])) {
    $config['title_image'] = 'images/librenms_logo_'.$config['site_style'].'.png';
}

I can't see any way $config['title_image'] could be unset?
any objections to me removing the test?

Thanks,
Aaron

@laf
Member
laf commented Nov 18, 2015

I've not had a proper look at the PR so I'll just comment on this last bit.

You can unset($config['title_image']); in config.php. But you are right, we don't necessarily know what logo is used (plus we have a couple for different style navbars).

@adaniels21487 adaniels21487 - Added 'Plugin' text, shrunk padding to fit in 1200w
cd62c1a
@laf
Member
laf commented Nov 19, 2015

@adaniels21487 - Thanks for giving the Webui some love :)

Had a proper look now. I'm a 👍 for this.

We probably should re-introduce the Plugins text as @Rosiak has mentioned.

@laf

Don't think this should be here :)

@adaniels21487
Contributor

Plugins returns :)
Let me know if you want me to change/break up the icon.

Thanks,
Aaron

@adaniels21487 adaniels21487 - Oops.. remove testing code.
cc9a6b5
@laf
Member
laf commented Nov 19, 2015

You have my 👍 when you remove the config setting you added :)

@Rosiak
Contributor
Rosiak commented Nov 20, 2015

👍 From here!

@laf laf added the WebUI label Nov 20, 2015
@laf laf merged commit 9e72b74 into librenms:master Nov 20, 2015

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
@adaniels21487 adaniels21487 deleted the adaniels21487:issue-2168 branch Dec 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment