Initial Public Statuspage #246

Merged
merged 7 commits into from Jun 25, 2014

Projects

None yet

3 participants

@bohdan-s
Contributor

Provides a publicly accessible list of servers and there status,
Disabled by default!!
When enabled it replaces the login page, show a status page before the login page.
Only change is to the index page to show the status rather than logon, all other changes are in new separate files, this should reduce risk.
This is an initial commit to provide basic functionality, will add features and clean up code in a new commit.

bohdan-s added some commits Jun 21, 2014
@bohdan-s
Contributor

Laf made some suggestions to previous code,
Removed commented out code,
Changed onClinck function to jGuery,
Cleaned up lots of useless code out of public.inc.php
commit 9fb82b8 contains the changes

@laf
Member
laf commented Jun 22, 2014

Hey bodah-s, looking good with this :)

The "$query = "SELECT * FROM devices ORDER BY hostname";" probably needs to exclude disabled and ignored devices.

Also just noticed that your html/pages/public.inc.php is outputting the footer and other things, I realise this may be because index.php exit's if it needs to call the login.inc.php. Probably best that we fix that rather than duplicating the code.

Apart from that it looks good. Nice work :)

@bohdan-s
Contributor

Laf, updated the code after your comments,
thanks for your input :)

@paulgear
Member

Hi bohdan-s,

Would you please have a read of doc/CONTRIBUTING.md and submit a separate pull request there for your contributor agreement? I also recommend that you add your own copyright notice to any new files.

Thanks,
Paul

@bohdan-s
Contributor

Updated Authors.md and added copyright.

@paulgear paulgear merged commit 7abdf8b into librenms:master Jun 25, 2014

1 check passed

default Scrutinizer: 14 new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment