Menubar Change #2593

Merged
merged 4 commits into from Dec 12, 2015

Projects

None yet

5 participants

@Rosiak
Contributor
Rosiak commented Dec 9, 2015

Fix #1575

screen shot 2015-12-09 at 23 32 22

@Rosiak Rosiak Menubar Change
Fix #1575
0d649c1
@SaaldjorMike
Member

Suggestion: Change it to grey instead of red when there are no unread messages.

@paulgear
Member

👍 to @SaaldjorMike's suggestion

@laf
Member
laf commented Dec 10, 2015

I do like it but......for 0-9 messages it 'just' about works - it looked better on your mock up.

Can you move the bubble slightly to the left so that it doesn't overlap with the next dropdown?

I'd also say 👍 to grey on 0 messages. Could you also add the number next to the notifications text in the actual drop down?

@Rosiak Rosiak Small fixes
- Make count smaller so it’ll fit.
- Change color of badge based on unread notifications or not.
6ffdd7a
@Rosiak Rosiak Add notification count to dd menu
3c3b322
@laf
Member
laf commented Dec 11, 2015

Hate to be picky :/ Is the fix for the overlap on the badge shrinking the font-size? If so it's now really illegible.

@Rosiak Rosiak Minor change
2f2d235
@laf
Member
laf commented Dec 12, 2015

👍 from me.

@librenms/reviewers

@SaaldjorMike SaaldjorMike merged commit 40b2b75 into librenms:master Dec 12, 2015

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
@Rosiak Rosiak deleted the Rosiak:issue-1575 branch Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment