First Draft in Per-User default dashboards #2620

Merged
merged 1 commit into from Dec 18, 2015

Projects

None yet

6 participants

@f0o
Member
f0o commented Dec 13, 2015

Fixes #2216 #1916

This is not final yet.
What hasn't been bothered with:

  • User can change his own defaults (Only admins can atm)
  • Dashboards permissions aren't revalidated

Help appreciated.

@f0o f0o First Draft in Per-User default dashboards
a63ea78
@f0o f0o added WebUI Schema labels Dec 13, 2015
@laf
Member
laf commented Dec 14, 2015

So this allows an admin to set what the default dashboard is for a user?

Should the list of dashboards on edit show the current users, that's what I see on my test at the moment but I thought it should be the list of dashboards of the user being edited?

@f0o
Member
f0o commented Dec 15, 2015

The dropdown shows a list of all dashboards the user has access to.
So own, shared(ro) and shared(rw).

On 14 December 2015 23:21:57 CET, Neil Lathwood notifications@github.com wrote:

So this allows an admin to set what the default dashboard is for a
user?

Should the list of dashboards on edit show the current users, that's
what I see on my test at the moment but I thought it should be the list
of dashboards of the user being edited?


Reply to this email directly or view it on GitHub:
#2620 (comment)

@laf
Member
laf commented Dec 15, 2015

Ok so If I select someone else's shared dashboard then that user should have it as the default? I'm not sure that happened last night but let me test again.

@f0o
Member
f0o commented Dec 15, 2015

Yeah it should unless I did a mistake

@laf laf merged commit dfb61fa into librenms:master Dec 18, 2015

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
@awlx
awlx commented Jan 15, 2016

Hm, it does not seem to work for me. I as a user selected the shared one of another. But everytime I select "overview" it's gone.

@higante702

Not trying to necro this thread, but I am in the same boat as @awlx - I set a dashboard and when we relog on or revisit the overview, it is set to "default"

@Rosiak
Contributor
Rosiak commented Apr 29, 2016

Is this the place where you set it?
Cause that works for me.
screen shot 2016-04-29 at 23 43 25

@higante702
higante702 commented Apr 29, 2016 edited

image

I thought that the edit users option would disappear because we have LDAP auth setup, or maybe im looking in an incorrect area?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment