Moved system polling module to core to centralise some snmpget calls #2637

Merged
merged 2 commits into from Jan 15, 2016

Projects

None yet

6 participants

@laf
Member
laf commented Dec 16, 2015

With this I've removed the 'system' polling module and moved it to core.inc.php

core.inc.php is now called for all polls regardless of the modules picked. Before hand some os files needed $poll_device data which was only available if you ran system,os. Whilst most of the time this would just be manual polling debugging that it would affect, the data it actually retrieves is used in a few places so it makes sense to grab this data and re-use it where possible.

I've also added some of the additional queries to the initial snmp_multi_get() so this saves at minimum 4 snmp queries but potentially 5-6 depending on the OS. Not a huge saving but every little helps.

@laf laf Moved system polling module to core to centralise some snmpget calls
821a797
@Rosiak
Contributor
Rosiak commented Dec 20, 2015

I don't have any proper install available to test this on at the moment, just to let you know.
But other than that, awesome!

@laf
Member
laf commented Dec 24, 2015

Bump

@Rosiak
Contributor
Rosiak commented Dec 24, 2015

I really don't have a proper install to test this with.

@paulgear
Member
paulgear commented Jan 1, 2016

Looks good to me; big 👍 to this sort of cleanup

@laf laf rebased
c1da4d8
@laf
Member
laf commented Jan 10, 2016

Rebased

@laf laf removed the Rebase Needed label Jan 10, 2016
@paulgear
Member

One Q: is the system -> core change just a straight rename?

@laf
Member
laf commented Jan 10, 2016

Yup, but I've left system in with a blank file as it's still a poller module.

@paulgear paulgear merged commit d1d3dba into librenms:master Jan 15, 2016

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer 1 new issues
Details
@laf laf deleted the laf:snmp-perf branch Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment