Smokeping: add pings config #2676

Merged
merged 6 commits into from Jan 5, 2016

Projects

None yet

5 participants

@paulgear
Member

This allows customising the number of pings to be graphed.

paulgear added some commits Dec 28, 2015
@paulgear paulgear Add pings option 66468d8
@paulgear paulgear Reduce the hate levels 81ac9fd
@paulgear paulgear Add install hint
793df90
@paulgear
Member

Should fix issue #2532.

@paulgear
Member
paulgear commented Jan 1, 2016

This should be a pretty simple one, @librenms/reviewers :-)

@Rosiak
Contributor
Rosiak commented Jan 2, 2016

👍

@f0o f0o and 1 other commented on an outdated diff Jan 2, 2016
includes/defaults.inc.php
@@ -458,6 +458,7 @@ function set_debug($debug) {
// Ignore lines starting with #
// $config['collectd_dir'] = '/var/lib/collectd/rrd';
// $config['smokeping']['dir'] = "/var/lib/smokeping/";
+$config['smokeping']['pings'] = 10;
@f0o
f0o Jan 2, 2016 Member

Why the change in default behavior and not keeping the old value like people are used to?

@paulgear
paulgear Jan 4, 2016 Member

Good point; will update

@paulgear paulgear Use old value for smokeping pings
184e20e
paulgear added some commits Jan 4, 2016
@paulgear paulgear Use old value for smokeping pings
d8fc1de
@paulgear paulgear Use old value for smokeping pings
a6f40b4
@laf laf merged commit 78a74ed into librenms:master Jan 5, 2016

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer 2 new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment