Add Port Notes Field #2688

Merged
merged 2 commits into from Jan 6, 2016

Projects

None yet

3 participants

@Rosiak
Contributor
Rosiak commented Jan 3, 2016

Add a “Notes” field for ports to accommodate #1897

@Rosiak Rosiak Add Port Notes Field
Add a “Notes” field for ports to accommodate #1897
d22fc18
@laf
Member
laf commented Jan 4, 2016

Rather than add another column is it not just worth using the device override table?

@Rosiak
Contributor
Rosiak commented Jan 4, 2016

Well, I honestly don't care.
If that's a more pretty way, I'll try that.

@laf
Member
laf commented Jan 4, 2016

You should only need to replace the dbUpdate calls to use something like set_dev_attr() and get_dev_attr() - names might be wrong :)

@Rosiak Rosiak Convert to device_attribs
8692345
@laf
Member
laf commented Jan 6, 2016

The only outstanding issue (and we have this with device notes) is that multi lines get converted to \n to be stored but not on the output so you end up with something\ntesting

@laf laf merged commit d4c4f9d into librenms:master Jan 6, 2016

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer 12 new issues
Details
@Rosiak Rosiak deleted the Rosiak:port-notes branch Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment