Fixed discovery+poller performance of VMware virtual machines. #2696

Merged
merged 2 commits into from Jan 8, 2016

Projects

None yet

5 participants

@SaaldjorMike
Member

BLOCKER: I've only got ESXi 6.0 hosts, so this should be tested on older platforms as well before merging.

Polling graph for an ESXi 6.0 host:
alt text
Polling graph provided by @Lucheni for an ESXi 5.5 host:

alt text

Before:

librenms@librenms01:~$ time ./discovery.php -h esx.example.dk -d -m vmware-vminfo | grep /usr/bin/snmp | wc -l
157

real    0m10.260s
user    0m6.268s
sys     0m3.422s

librenms@librenms01:~$ time ./poller.php -h esx.example.dk -d -r -m os | grep /usr/bin/snmp | wc -l
159

real    0m12.190s
user    0m6.492s
sys     0m4.830s

After:

librenms@librenms01:~$ git checkout vmware-polling-perf
librenms@librenms01:~$ time ./discovery.php -h esx.example.dk -d -m vmware-vminfo | grep /usr/bin/snmp | wc -l
1

real    0m0.169s
user    0m0.098s
sys     0m0.045s

librenms@librenms01:~$ time ./poller.php -h esx.example.dk -d -r -m os | grep /usr/bin/snmp | wc -l
5

real    0m0.758s
user    0m0.160s
sys     0m0.172s
SaaldjorMike added some commits Jan 5, 2016
@SaaldjorMike SaaldjorMike Fixed discovery performance of VMware virtual machines.
a42e3da
@SaaldjorMike SaaldjorMike Fixed polling performance of VMware virtual machines.
9112153
@SaaldjorMike SaaldjorMike added the Blocker label Jan 5, 2016
@SaaldjorMike SaaldjorMike changed the title from Fixed discovery performance of VMware virtual machines. to Fixed discovery+poller performance of VMware virtual machines. Jan 5, 2016
@onestackGit

Can help test this tomorrow if it is still needed.

@laf
Member
laf commented Jan 6, 2016

@Lucheni That would be awesome. Thanks :)

@f0o
Member
f0o commented Jan 8, 2016

@SaaldjorMike @Lucheni how's the status on this? Blocker still valid?

@onestackGit

Not sure what that term means means. But I saw big polling improvements across four esxi hosts, hosting 20+ vms with all vm data still present.

@laf laf merged commit 4e127af into librenms:master Jan 8, 2016

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
@SaaldjorMike SaaldjorMike removed the Blocker label Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment