No description provided.
Added username support for libvirt over SSH
Auto-Deploy finished, Test PR at http://2728.ci.librenms.org or https://2728.ci.librenms.org
Can you sign the contributors agreement please?
I agree to the conditions of the Contributor Agreement contained in d…
I think isset or !empty would be preferred here.
$config['libvirt_username'] is predefined in the defaults with a NULL-value. I personally do not like empty() because is also returns true on zero (which might be the value you want to use)
That's true, as unlikely as a username of 0 might be ;D.
But I do think isset is more clear for readability and isset is only false if the variable is null or undefined.
I'd say isset may be better as well.
Changed check to isset() and removed default setting from defaults.inc.php. It looks like the auto-deploy-check hangs for some reason.