Create zyxelgs.inc.php #2729

Merged
merged 2 commits into from Jan 10, 2016

Projects

None yet

3 participants

@davehope
Contributor
davehope commented Jan 9, 2016

Add support for Zyxel GS1910-24HP (And likely others).

@davehope davehope Create zyxelgs.inc.php
Add support for Zyxel GS1910-24HP (And likely others)
152c45b
@davehope
Contributor
davehope commented Jan 9, 2016

Tested against my home Zyxel GS1910-24HP.

@laf
Member
laf commented Jan 10, 2016

Thanks @davehope

If this is placing these devices as $os = 'zyxeles' then this code needs to be in:

includes/discovery/os/zyxeles.inc.php

Is that the correct os for them though?

@davehope
Contributor

@laf
The GS, ES and XGS switches use the ZyNOS os. There may be some models that don't, though looking through various manuals for products across the range they all refer to ZyNOS.

Would you like this added into zyxeles.inc.php, or a new file created named zynos.inc.php created and the two merged? If the files are merged, it may make sense to rename the $os to ZyNOS and update definitions.inc.php accordingly?

Dave Hope Merged changes for Zyxel ES and GS series switches under 'Zynos'.
7fbdb5e
@laf laf merged commit e3e1b5f into librenms:master Jan 10, 2016

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment