Added config option to force showing sysName instead of IP #2796

Merged
merged 1 commit into from Jan 19, 2016

Projects

None yet

4 participants

@laf
Member
laf commented Jan 17, 2016

Fix #2091

Anywhere we use generate_device_link(), this will now change the 'hostname' if it's an IP to use sysName instead. I'm sure we will still have areas that we need to update to use this properly but it works in the device list + the two widgets requested in that issue.

@laf laf Added config option to force showing sysName instead of IP
5e37de8
@laf laf added the WebUI label Jan 17, 2016
@f0o f0o merged commit ded1fa3 into librenms:master Jan 19, 2016

1 of 2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
@paszczus

thank you @laf :)

@laf laf deleted the laf:issue-2091 branch Jan 19, 2016
@jmoore2016

Hello, I am trying to get this working in the latest version and it does not seem to work. I uncommented the line in /includes/default.inc.php and added it to config.php with no luck. Do you have any advice?

@paszczus
paszczus commented Aug 2, 2016

You don't need to uncomment default.inc.php. You only need to add $config['discovery_by_ip'] = true; in config.php.
It does not work with Avability map widget.

@jmoore2016

I am expecting this to work for the general "device list". I am adding hosts using scan_snmp.php and they are not using SNMP sysName. I have tried config.php for the changes as well.

Sent from my iPhone

On Aug 2, 2016, at 5:18 PM, paszczus notifications@github.com wrote:

You don't need to uncomment default.inc.php. You only need to add $config['discovery_by_ip'] = true; in config.php.
It does not work with Avability map widget.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@laf
Member
laf commented Aug 2, 2016

Please create an issue.

@laf laf locked and limited conversation to collaborators Aug 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.