Added the lookup of IP if device hostname is a hostname #2798

Merged
merged 5 commits into from Jan 19, 2016

Projects

None yet

3 participants

@laf
Member
laf commented Jan 18, 2016

Fix #1698

This now does a dns lookup on hostnames only for an IP. It stores it as a varbinary(16) which is the correct way to store ipv4/ipv6 by all accounts. At present no mysql functions are used as they only exist in 5.6 and above so this is all done in php.

laf added some commits Jan 17, 2016
@laf laf Added the lookup of IP if device hostname is a hostname
49adff3
@laf laf Added check for hostname cc25e87
@laf laf added Polling WebUI labels Jan 18, 2016
@f0o
Member
f0o commented Jan 18, 2016

Dislike the modification to the devices-table's schema, it has always caused some problems. Isn't there a way around with using the devices_attribs? If not, never mind my comment

@laf
Member
laf commented Jan 18, 2016

The biggest issue with devices_attribs is the column type, as we already know for the IP address tables having them as just varchars means we lose a lot of functionality in converting and searching so we really should be using the correct column type to store this information.

@laf laf Updated for Scrut fix
47ff913
@f0o
Member
f0o commented Jan 19, 2016

Ok, I can live with devices then. Thanks for clarifying :)

@laf laf Rebased includes/common.php
3a8b0b0
@laf
Member
laf commented Jan 19, 2016

Rebased.

@f0o
Member
f0o commented Jan 19, 2016

heh needs another rebase. CI worked out well though! :)

@laf laf Rebased (sql schema conflict)
2dec9c3
@laf
Member
laf commented Jan 19, 2016

Rebased again :)

@f0o f0o merged commit 4ab1075 into librenms:master Jan 19, 2016

1 of 2 checks passed

Scrutinizer Running
Details
Auto-Deploy Build finished. No test results found.
Details
@laf laf deleted the laf:issue-1698 branch Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment