Add infoblox devices (Issue 2708) #2801

Merged
merged 8 commits into from Jan 19, 2016

Projects

None yet

6 participants

@wiad
Contributor
wiad commented Jan 18, 2016

MIBS available at http://www.oidview.com/mibs/7779/md-7779-1.html

First attempt at adding device, not sure everything is kosher.

wiad and others added some commits Jan 18, 2016
wiad Addes support for infoblox devices 65176c0
@wiad wiad add infoblox
4a0cc16
@wiad wiad referenced this pull request Jan 18, 2016
Closed

Add Infoblox device #2708

@f0o
Member
f0o commented Jan 19, 2016

Can you provide a device for the CI to test against?
I can give you an IP we would be using or even setup a VPN to your aite to comply with data security policies of your company.
Preferably this particular comversation should be continued via email f0o@librenms.org, GPG available on keyservers :)

wiad added some commits Jan 19, 2016
@wiad wiad Merge branch 'master' of https://github.com:/wiad/librenms into issue…
…-2708

Conflicts:
	includes/definitions.inc.php
086443b
@wiad wiad fix if statement style
913314f
@laf
Member
laf commented Jan 19, 2016

@wiad You've got a php syntax issue in includes/definitions.inc.php The merge conflict was in that file and it's not been fixed. Look for >>>>> and you will see.

@laf laf and 1 other commented on an outdated diff Jan 19, 2016
includes/discovery/os/nios.inc.php
@@ -0,0 +1,10 @@
+<?php
+if (!$os || $os === 'linux') {
+ if (stristr($sysObjectId, ".1.3.6.1.4.1.7779.1")) {
+ $os = 'nios';
+ }
+}
+
@laf
laf Jan 19, 2016 Member

Lots of blank lines here, can you remove those please.

@f0o
f0o Jan 19, 2016 Member

I'll be around his work soon and try out the PR on his gear. Will do some fixes from there if needed.
Looking forward to another device being added 👍

On 19 January 2016 11:31:51 CET, Neil Lathwood notifications@github.com wrote:

@@ -0,0 +1,10 @@
+<?php
+if (!$os || $os === 'linux') {

  • if (stristr($sysObjectId, ".1.3.6.1.4.1.7779.1")) {
  •    $os = 'nios';
    
  • }
    +}

Lots of blank lines here, can you remove those please.


Reply to this email directly or view it on GitHub:
https://github.com/librenms/librenms/pull/2801/files#r50096133

wiad added some commits Jan 19, 2016
@wiad wiad fix syntax 71195bc
@wiad wiad fix syntax 2883759
@wiad wiad Merge branch 'master' of https://github.com:/wiad/librenms into issue…
…-2708
45e412f
@paulgear
Member

👍 from me; new device type, so shouldn't affect anything serious.

@f0o f0o was assigned by laf Jan 19, 2016
@laf laf removed the Rebase Needed label Jan 19, 2016
@SaaldjorMike SaaldjorMike merged commit e021cf8 into librenms:master Jan 19, 2016

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer 2 new issues
Details
@wiad wiad deleted the wiad:issue-2708 branch Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment