Added ability to ignore device sensors from entity mib #2862

Merged
merged 3 commits into from Feb 3, 2016

Projects

None yet

5 participants

@laf
Member
laf commented Jan 25, 2016

Fix #2859

This allows people to set either global or per OS descriptions that can be ignored for Entity sensors.

laf added some commits Jan 25, 2016
@laf laf Added ability to ignore device sensors from entity mib 427c4f0
@laf laf Added docs information on using the new config options
d8c4916
@laf laf added the Discovery label Jan 25, 2016
@f0o f0o and 1 other commented on an outdated diff Jan 26, 2016
includes/discovery/sensors/entity-sensor.inc.php
@@ -50,7 +50,7 @@
$descr = rewrite_entity_descr($descr);
}
- $thisisnotbullshit = true;
+ $thisisnotbullshit = check_entity_sensor($descr, $device);
@f0o
f0o Jan 26, 2016 Member

Can you substitute this variable name? Its really not appealing and makes me remember the tyranny of the unspoken one

@paulgear
paulgear Jan 27, 2016 Member

👍 to @f0o's comment :-)

@laf laf Updated thisisnotbullshit variable
3560a39
@laf
Member
laf commented Jan 28, 2016

Updated.

@laf
Member
laf commented Jan 28, 2016

Scrut issues seem daft on this one.

@Rosiak
Contributor
Rosiak commented Feb 1, 2016

👍
Gents?

@paulgear
Member
paulgear commented Feb 1, 2016

👍 Scrutinizer does seem to be particularly daft on this one. No issues from my perspective.

@laf
Member
laf commented Feb 2, 2016

Care to merge then :)

@paulgear paulgear merged commit a81776e into librenms:master Feb 3, 2016

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer 3 new issues
Details
@laf laf deleted the laf:issue-2859 branch Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment