Added description of AD configuration options #2910

Merged
merged 2 commits into from Feb 2, 2016

Projects

None yet

3 participants

@awlx
awlx commented Feb 2, 2016

Stumbled across this description and had to search the code what really needs to be set. So I thought this might be a better description.

@awlx awlx Added description of AD configuration options
a53f7c3
@laf
Member
laf commented Feb 2, 2016

I think it would be better not to use <> for the names. Maybe even be more explicit what can be customised.

@awlx
awlx commented Feb 2, 2016

Well I used this: http://docs.librenms.org/Installation/Installation-(RHEL-CentOS)/ as an example, they use <> too.

And I thought it will be clear this way. Well at least better then before ;). But maybe it's better to change it to "Replace with your desired Active Directory Admingroup".

@laf
Member
laf commented Feb 2, 2016

The install docs specifically tell people to replace with the IP though, if you do that it will be fine but it just needs to be clear.

@awlx awlx Changed the text to make it more clear what to change.
53be46e
@awlx
awlx commented Feb 2, 2016

Ok, changed it.

@laf laf merged commit c3d5a2a into librenms:master Feb 2, 2016

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
@laf
Member
laf commented Feb 2, 2016

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment