Add systemd unit file for the python poller service. #2913

Merged
merged 2 commits into from Feb 7, 2016

Projects

None yet

5 participants

@murrant
Contributor
murrant commented Feb 2, 2016

Add systemd unit file for the python poller service.

@f0o
Member
f0o commented Feb 2, 2016

I dislike having it in the top directory, it's already rather messy...
Can you move it to scripts?

@paulgear
Member
paulgear commented Feb 2, 2016

@f0o If we're going to say that, we probably need to say that for a bunch of other things too.

@laf
Member
laf commented Feb 2, 2016

Your both right but there's no reason to add more cruft to the / dir so +1 to move to another directory.

We also need a doc explaining how to use this.

@murrant
Contributor
murrant commented Feb 3, 2016

I agree as well, If I get some time I'll move them into the scripts directory and update the documentation.
Any objections with renaming the init scripts to librenms-poller?

@murrant murrant Add systemd unit file for the python poller service.
Move poller-service init scripts into to scripts directory and update the documentation.
44cd86d
@murrant
Contributor
murrant commented Feb 3, 2016

Moving the scripts will cause issues for users that have followed the documentation and made a link to the files.

@laf
Member
laf commented Feb 3, 2016

Can't believe we merged it in (probably me :/), we stopped symlinking stuff last time we had this issue with the cron file.

imho we send notices out about this and set a date to merge.

@murrant Can you update the docs to do cp X Y rather than ln -s (across the whole doc not just the new bit).

@murrant
Contributor
murrant commented Feb 3, 2016

@laf will do

@murrant murrant Change the poller-service docs from ln -s to cp to prevent us from br…
…eaking user's installs.
aa43f41
@murrant
Contributor
murrant commented Feb 3, 2016

Perhaps we should send a notification about the service files moving so we don't break users that used ln -s. I'm not sure how many users use the poller-service and might have linked the service files.

@f0o f0o merged commit b118ee5 into librenms:master Feb 7, 2016

1 of 2 checks passed

Auto-Deploy Triggered
Details
Scrutinizer No new issues
Details
@murrant murrant deleted the murrant:poller-service-systemd branch Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment