Disabling auto-updates doesn't work #3063

merged 3 commits into from Feb 26, 2016


None yet

3 participants


Disabling auto-updates doesn't actually disable them.

  1. It still does the innodb check (I'm not sure what this is for, if the pools are incorrect, that may affect performance but it won't stop a schema from being upgraded).

  2. It still does the post-pull tasks (trying to update the submodules).

Made it do the auto-update check before doing anything else and if it's disabled, then the daily script will check for any schema changes to be applied and a db cleanup.

Christopher ... added some commits Feb 22, 2016
Christopher Smith check if auto-updates are enabled before checking innodb settings (if…
… they are disabled, this would still throw an alert to say innodb needs adjusting even though they arent wanted)
Christopher Smith check if daily.php returns 0 and only do the db clean up if it does (…
…dont update submodules or do a schema upgrade etc)
Christopher Smith if no code is updated, do a schema update check and also a cleanup. m…
…ove to a separate script call to make it easier to add more tasks if required in the future.
laf commented Feb 23, 2016

Works for me.


@laf laf merged commit cbc039f into librenms:master Feb 26, 2016

1 of 2 checks passed

Scrutinizer Errored
Auto-Deploy Build finished. No test results found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment