ServerIron / ServerIron ADX support #3074

Merged
merged 10 commits into from Mar 3, 2016

Projects

None yet

7 participants

@xbeaudouin
Contributor

Here the ServerIron ADX support for librenms

Regards

xbeaudouin added some commits Feb 23, 2016
@xbeaudouin xbeaudouin Initial commit for ServerIron support 63a76a7
@xbeaudouin xbeaudouin This is in fact a load balancer d10b944
@xbeaudouin xbeaudouin Better ServerIron support
51d1a89
@laf
Member
laf commented Feb 23, 2016

👍 from me.

@xbeaudouin xbeaudouin Forgot to add the Chassis temperature
6d1960f
@xbeaudouin
Contributor

I just saw I forgot to add the Chassis Temperature sensor :D

@xbeaudouin xbeaudouin Fixed S/B, Hardware and OS detectio
ca21b87
@xbeaudouin xbeaudouin Typo that make mempool non working => fixed
760f1be
@xbeaudouin
Contributor

ping ?

@murrant murrant and 1 other commented on an outdated diff Feb 29, 2016
...des/discovery/sensors/temperatures/serveriron.inc.php
@@ -0,0 +1,33 @@
+<?php
+
+if ($device['os'] == 'serveriron') {
+ echo(" FOUNDRY-SN-AGENT-MIB ");
+
+ // Chassis temperature (default)
+ $high_limit = 110;
+ $high_warn_limit = 95;
+
+ $descr = "Chassis Temperature";
+ $oid = "1.3.6.1.4.1.1991.1.1.1.1.18.0"; // snChasActualTemperature
+ $warn_oid = "1.3.6.1.4.1.1991.1.1.1.1.19.0"; // snChasWarningTemperature
+ $high_oid = "1.3.6.1.4.1.1991.1.1.1.1.20.0"; // snChasShutdownTemperature
+ $value = snmp_get($device, $oid, '-Oqv', 'FOUNDRY-SN-AGENT-MIB');
@murrant
murrant Feb 29, 2016 Contributor

You don't need to specify a mib for files that use raw oids. Just a minor thing, but it is done multiple times.

@xbeaudouin
xbeaudouin Mar 1, 2016 Contributor

I can fix that. Either put the symbolic name or remove the MIB.
What do you mean by "it is done multiple times"?

Regards

@xbeaudouin xbeaudouin Removed specified MIB file for ServerIron temperatures since the OID …
…used is RAW
386ad10
@xbeaudouin
Contributor

@murrant fixed the temperature/sensor. Can you have a look ?

@xbeaudouin xbeaudouin Add Power Supply and Fan status
37e8b2d
@xbeaudouin xbeaudouin Added some MIB polling specific stuff for ServerIron
669841a
@Rosiak
Contributor
Rosiak commented Mar 1, 2016

👍

@paulgear
Member
paulgear commented Mar 2, 2016

@xbeaudouin Looks like there are some mixed spaces & tabs in includes/discovery/sensors/temperatures/serveriron.inc.php and includes/discovery/os/serveriron.inc.php (that I could see). Would you mind getting rid of the tabs before we merge?

@f0o
Member
f0o commented Mar 2, 2016

Agree with @paulgear

@xbeaudouin
Contributor

@paulgear Sure will do RSN.

@xbeaudouin xbeaudouin Tab => spaces
1c65acc
@xbeaudouin
Contributor

Done :D

@murrant murrant merged commit a57d212 into librenms:master Mar 3, 2016

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer 6 new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment