Create qnap.inc.php #3088

Merged
merged 1 commit into from Feb 26, 2016

Projects

None yet

4 participants

@GeorgesDick
Contributor

Get QNAP Turbo NAS Fans speeds

@GeorgesDick GeorgesDick Create qnap.inc.php
Get QNAP Turbo NAS Fans speeds
02b0c8b
@laf
Member
laf commented Feb 25, 2016

Just as an FYI, you can submit things like this in one PR for future. Multiple commits showing each is fine but not necessary for small commits.

@GeorgesDick
Contributor

Di you mean that I can add (or edit) multiple files, and then submit only
one PR at the end?

Thank you for your help,
Georges

2016-02-25 10:34 GMT+01:00 Neil Lathwood notifications@github.com:

Just as an FYI, you can submit things like this in one PR for future.
Multiple commits showing each is fine but not necessary for small commits.


Reply to this email directly or view it on GitHub
#3088 (comment).

Cordialement,

Georges DICK
email georges@monaco.net
http://georgesdick.com

@laf
Member
laf commented Feb 25, 2016

Yes that's correct. Let's take these two as an example:

Edit includes/discovery/sensors/fanspeeds/qnap.inc.php and do what you need.
git add includes/discovery/sensors/fanspeeds/qnap.inc.php (only needed when first creating the file).
git commit -a -m 'Added fanspeeds support to qnap devices'
Edit includes/discovery/sensors/temperatures/qnap.inc.php
git add includes/discovery/sensors/temperatures/qnap.inc.php
git commit -a -m 'Added temperature support to qnap devices'
git push

@GeorgesDick
Contributor

Tahnks !

And when using Github website?

  • "Propose new file" (or ("Propose file change")
  • "Propose new file" (or ("Propose file change")
    (etc.)
  • "New Pull Request"

Am I correct?

2016-02-25 12:22 GMT+01:00 Neil Lathwood notifications@github.com:

Yes that's correct. Let's take these two as an example:

Edit includes/discovery/sensors/fanspeeds/qnap.inc.php and do what you
need.
git add includes/discovery/sensors/fanspeeds/qnap.inc.php (only needed
when first creating the file).
git commit -a -m 'Added fanspeeds support to qnap devices'
Edit includes/discovery/sensors/temperatures/qnap.inc.php
git add includes/discovery/sensors/temperatures/qnap.inc.php
git commit -a -m 'Added temperature support to qnap devices'
git push


Reply to this email directly or view it on GitHub
#3088 (comment).

Cordialement,

Georges DICK
email georges@monaco.net
http://georgesdick.com

@murrant
Contributor
murrant commented Feb 25, 2016

Github allows you to select the branch when doing things in the webui. Make sure you use the same branch as the first, rather than creating a new branch. This will allow you to create a PR from that branch when you are done.

@GeorgesDick
Contributor

I created a new file, edited a second one, but can't find how to submit
this in only one pull request: I can see two "Compare & pull request"
buttons, but no way to merge...

2016-02-25 17:20 GMT+01:00 Tony Murray notifications@github.com:

Github allows you to select the branch when doing things in the webui.
Make sure you use the same branch as the first, rather than creating a new
branch. This will allow you to create a PR from that branch when you are
done.


Reply to this email directly or view it on GitHub
#3088 (comment).

Cordialement,

Georges DICK
email georges@monaco.net
http://georgesdick.com

@GeorgesDick
Contributor

Hello,

Second try: I cloned librenms on my Linux box, edited/added three files,
but at the last step (git pull), after entering username/password I have an
error message:
remote: Permission to librenms/librenms.git denied to GeorgesDick.
fatal: unable to access 'https://github.com/librenms/librenms.git/': The
requested URL returned error: 403

Sorry to bother you but, although I'm writing code since more than 20
years, and I already contributed to a couple of Open Source projects, I'm
really new to github.

KR,
Georges

2016-02-25 17:20 GMT+01:00 Tony Murray notifications@github.com:

Github allows you to select the branch when doing things in the webui.
Make sure you use the same branch as the first, rather than creating a new
branch. This will allow you to create a PR from that branch when you are
done.


Reply to this email directly or view it on GitHub
#3088 (comment).

Cordialement,

Georges DICK
email georges@monaco.net
http://georgesdick.com

@laf
Member
laf commented Feb 26, 2016

It's no problem. The issue there is you are trying to upload straight to our repo. You need to do this to your own.

We have a doc that goes in to how best to manage the repo: http://docs.librenms.org/Developing/Using-Git/

For now, we'll merge these ones it's more just an fyi.

@laf laf merged commit da0ad58 into librenms:master Feb 26, 2016

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer 2 new issues
Details
@laf laf added the Discovery label Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment