This should cover the examples I could find on the web, but we could be missing some corner cases.
If we fail, the entire message is in msg, instead of being lost.
Simplify Cisco ios,iosxe,catos log processing.
Auto-Deploy finished, Test PR at http://3099.ci.librenms.org or https://3099.ci.librenms.org
First off, I don't manage any devices affected by this, only interested in the syslog parsing (see #3036) and origin of the old code so to speak.
If I understand correctly, the edge cases are:
%CARD-SEVERITY-MSG:SLOT %FACILITY-SEVERITY-MNEMONIC: Message-text
Thanks @Ultra2D. I thought I had %? in there at some point, must have snuck out. I'll go through these later.
This should process all of the messages on these sites and if it fail…
…s, there should be no data loss
@librenms/reviewers Any thoughts on this?
Still nervous about things like this as we just don't 100% know the impact for people :/
If we were to merge, I'd propose a message out via the notifications.xml to let people know.
Maybe, it has been totally broken for my Cisco devices since I set it up on my production server. All I get is % in the logs.
Unit tests would help, but I have no idea how to set that up.
If you just add a new entry to misc/notifications.xml and add a new entry just saying that we've merged this in and if you use syslogging with cisco kit then keep an eye on it.
move the negation outside of the regular expression for more accurate…
The old load included the leading %. Stick with that behavior.
PHPunit tests for Cisco syslog parsing.
Notifcation and tab->spaces fix.
Enable phpunit testing in Travis CI.
@murrant There is a single tab character on line 86 of tests/SyslogTest.php. Could you convert it to spaces?
This pr has been merged so it would need to be a separate pr.