Updated authToken response code to be 401 #310

merged 1 commit into from Oct 22, 2014


None yet

2 participants

laf commented Oct 7, 2014

Looks like 401 is the correct response code for authentication issues:


It does say the response must include a www-authenticate header which we don't send as it's done via a custom header.

Feel free to comment and close this if you feel 403 is still the correct response.

laf commented Oct 9, 2014

p.s checked and github use 401 when using oAuth and failing. :)

@laf laf added the scrutinizer-ok label Oct 9, 2014
@paulgear paulgear merged commit 9bf617b into librenms:master Oct 22, 2014

1 check passed

ci/scrutinizer Scrutinizer: No new issues
@laf laf deleted the unknown repository branch Apr 30, 2015
@paulgear paulgear pushed a commit that referenced this pull request Jul 26, 2015
@danzel danzel Fire animationend event even in non-animated versions of the zoom in/…
…out animation. Makes oldie fire the same events as modern browsers. Fixes #310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment